feat: [Context Switching] Maintain datasource collapse state #17616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core-navigation # Conflicts: # app/client/src/ce/constants/ReduxActionConstants.tsx # app/client/src/navigation/FocusElements.ts # app/client/src/pages/Editor/APIEditor/Form.tsx
…th into chore/datasource-accordion-state
…th into chore/datasource-accordion-state
|
/ok-to-test sha=adca177 |
hetunandu
changed the title
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3593061085. |
…datasource-accordion-state
|
/ok-to-test sha=5c932eb |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3599515334. |
hetunandu
approved these changes
Dec 5, 2022
tanvibhakta
added a commit
that referenced
this pull request
Dec 6, 2022
* replace BlackAuthCardNavLink with Link from design system * Replace AuthCardNavLink with Link from design system * Refactor ForgotPasswordLink to use Link from design-system * use variables from ads * replace FooterLinks with Link * bump design-system alpha version * fix issue with Segment header props * Add font size for ForgotPassword explicitly * bump alpha version * Make "Sign In" text primary as well * Update ds alpha version * use TextType in location * use typography constants from design-system * update alpha version * bump design-system version * Empty-Commit * use correct typographic variables * fix: Form message component link issue * removed the inverted flag for testing * Update to use correct variable * Change floatingBtn in DefaultTheme file * fix: Made changes to pass action link element to design system component - formMessage * chore: update design-system version to fix issue with radio * Remove unnecessary imports * fix Merge_spec.js cypress test * fixed conflict with react router Link and design system Link * chore: dependentbot vulnerabilities. (#18528) * fix: dependentbot vulnerabilities. * chore: remove emoji-mart. * chore: updated react-syntax-highlighter * chore: update ts-loader add loader-utils resolution. Co-authored-by: Aishwarya UR <[email protected]> * fix: Added support for country code flags on windows devices (#18203) * fix: add pollyfill and use font family. * fix: use latest version design system. Co-authored-by: Aishwarya UR <[email protected]> * fix: Updating spec for member roles (#18657) updated spec for member roles * feat: [Context Switching] Maintain datasource collapse state (#17616) * chore: Remove debugging logs for analytics (#18662) * chore: Support using custom port(s) for listening in the start-https.sh script (#18451) Added `--https-port` and `--http-port`, so you can set a custom port instead of the default 80 and 443. This is useful if you want to test Appsmith when using a non-standard port, fox example, how `appsmith.URL.host` behaves, or how OAuth redirects behave etc. We also add a shortcut to start this with release endpoint. Just using `release` is now the same thing as using `https://release.app.appsmith.com`. This is useful to people like me who are _very_ good with typos. * feat: Adding Embedding Apps Functionality in the API (#18566) * chore: fix ingress fieldname in appsmith (#18684) * fix: Auto height breaks for fixed modal's children (#18691) Fix issue where auto height was throwing an error when a fixed modal widget's children were changing height automatically * fix: datasource autosave git issue fixed (#18690) * datasource autosave git issue fixed * Added appropriate comments Co-authored-by: “sneha122” <“[email protected]”> * chore: Improved metadata on logs when reading DSL fails (#18692) * chore: Improved metadata on logs when reading DSL fails * Fixed test * Test fix * Review comment * Update top contributors * chore: bump ds version to use better MenuDivider type Co-authored-by: Albin <[email protected]> Co-authored-by: Parthvi Goswami <[email protected]> Co-authored-by: Arsalan Yaldram <[email protected]> Co-authored-by: Aishwarya UR <[email protected]> Co-authored-by: Ankita Kinger <[email protected]> Co-authored-by: akash-codemonk <[email protected]> Co-authored-by: Anagh Hegde <[email protected]> Co-authored-by: Shrikant Sharat Kandula <[email protected]> Co-authored-by: Nilansh Bansal <[email protected]> Co-authored-by: Goutham Pratapa <[email protected]> Co-authored-by: Abhinav Jha <[email protected]> Co-authored-by: sneha122 <[email protected]> Co-authored-by: “sneha122” <“[email protected]”> Co-authored-by: Nidhi <[email protected]> Co-authored-by: Appsmith Bot <[email protected]>
|
Caution Review failedThe pull request is closed. WalkthroughThe recent changes enhance the application's ability to maintain the collapse state of data source sections during context switching. New test cases were introduced to verify this functionality, alongside improvements in the UI component structure, Redux actions, and state management. This ensures a seamless user experience, allowing users to switch between data sources without losing their interface state. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maintain datasource collapse state when switching back to the datasource.
Media
collapse.mov
Code changes
Fixes #17439
Type of change
How Has This Been Tested?
Cypress
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor
Collapsiblecomponent from a class-based to a functional component for better readability and performance.